-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating XEP-0060 Publish-Subscribe #4092
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4092 +/- ##
==========================================
+ Coverage 83.85% 83.90% +0.04%
==========================================
Files 551 551
Lines 33568 33594 +26
==========================================
+ Hits 28149 28186 +37
+ Misses 5419 5408 -11
☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
2fe9d60
to
ed3b986
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ed3b986
to
e54ca55
Compare
e54ca55
to
ff69e49
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cc68fca
to
54adfc0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
elasticsearch_and_cassandra_25 / elasticsearch_and_cassandra_mnesia / ea8e8ce small_tests_24 / small_tests / ea8e8ce small_tests_25 / small_tests / ea8e8ce small_tests_25_arm64 / small_tests / ea8e8ce ldap_mnesia_24 / ldap_mnesia / ea8e8ce dynamic_domains_mysql_redis_25 / mysql_redis / ea8e8ce dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / ea8e8ce ldap_mnesia_25 / ldap_mnesia / ea8e8ce dynamic_domains_pgsql_mnesia_24 / pgsql_mnesia / ea8e8ce internal_mnesia_25 / internal_mnesia / ea8e8ce dynamic_domains_mssql_mnesia_25 / odbc_mssql_mnesia / ea8e8ce pgsql_mnesia_24 / pgsql_mnesia / ea8e8ce pgsql_cets_25 / pgsql_cets / ea8e8ce pgsql_mnesia_25 / pgsql_mnesia / ea8e8ce mssql_mnesia_25 / odbc_mssql_mnesia / ea8e8ce mysql_redis_25 / mysql_redis / ea8e8ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Include a feature of http://jabber.org/protocol/pubsub#rsm in disco#info response.
Check preconditions when accepting publish-options along with a publish request. We have two node types which advertise support for the publish-options feature.
In node push the preconditions are not checked. This node type is supporting xep-0163.
In node pep the changes are implemented, and the publish-options are being checked.